fix: update fhir-converter to dotnet 8 #3080
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3080 +/- ##
==========================================
- Coverage 86.54% 85.14% -1.41%
==========================================
Files 215 189 -26
Lines 13432 10945 -2487
Branches 668 705 +37
==========================================
- Hits 11625 9319 -2306
+ Misses 1798 1617 -181
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. |
mcmcgrath13
requested review from
akasper,
angelathe,
austin-hall-skylight,
BobanL,
gordonfarrell,
JNygaard-Skylight,
lina-roth and
robertmitchellv
as code owners
containers/fhir-converter/Dockerfile
Outdated
|
|
||
| # Download FHIR-Converter | ||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch v7.0-skylight-18 --single-branch /build/FHIR-Converter | ||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch mcm/dotnet-8 --single-branch /build/FHIR-Converter |
There was a problem hiding this comment.
todo: update to release version before merge
|
I ran the integration tests and convert-seed-data and didn't have any issues. I think that should cover it since there's no code changes on this end to review, right? |
Yeah, it's just the dockerfile here. The main outstanding question is performance and the tradeoffs since the latest changes seem to be slower even though they should be newer and shinier |
PULL REQUEST
Summary
Pull in latest updates from upstream Microsoft FHIR Converter, including updgrade to dotnet 8, which requires updating the dockerfile for the service. Corresponds to skylight-hq/FHIR-Converter#25
Related Issue
Fixes #3060